Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare metadata for goa mirror #2048

Merged
merged 4 commits into from
Aug 25, 2023
Merged

prepare metadata for goa mirror #2048

merged 4 commits into from
Aug 25, 2023

Conversation

kltm
Copy link
Member

@kltm kltm commented Aug 25, 2023

@kltm kltm requested a review from dustine32 August 25, 2023 20:58
dustine32
dustine32 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@dustine32 dustine32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to test. So, ontobio will start downloading from https://mirror.geneontology.io/ (for goa at least) since it always uses the source field and of course there should always be some file at that source location.

@kltm
Copy link
Member Author

kltm commented Aug 25, 2023

@dustine32 Correct: anything using the source field in this metadata file will start grabbing from the mirror.
The mirror is populated in a very basic way from the goa-copy-to-mirror branch, moving files to the go-mirror bucket, which then has Cloud Front producing mirror.geneontology.io.
That said, I think the new location should only be an improvement for most practical purposes. I'm not sure how to test here besides letting the pipelines at the new files.

@dustine32
Copy link
Contributor

@kltm Oh sorry, I guess by "test" I meant let them run and in the unlikely event it doesn't work we'll change back (there's probably a better word).

@kltm kltm merged commit ab0cf8a into master Aug 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustine32 dustine32 dustine32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kltm @dustine32